Skip to content

Update Documentation about SFT Config #2649

Description

@ParagEkbote

Reproduction

Since the max_seq_length parameter was deprecated in #2306, the relevant documentation pertaining to it is not updated in the documentation as seen here.

Additionally, the SFT config class has kept the deprecated parameter.

https://github.com/huggingface/trl/blob/8e65825d4cb22cf304bcd245adef978c473efcb1/trl/trainer/sft_config.py#L80C2-L81C22

Could you please let me know what improvements are needed and I will be happy to contribute to update the documentation.

cc: @qgallouedec

For more info, please see this issue here.

System Info

Platform: Linux-6.5.0-1025-azure-x86_64-with-glibc2.31

  • Python version: 3.12.1
  • PyTorch version: 2.5.1+cpu
  • CUDA device(s): not available
  • Transformers version: 4.48.1
  • Accelerate version: 1.3.0
  • Accelerate config: not found
  • Datasets version: 3.2.0
  • HF Hub version: 0.27.1
  • TRL version: 0.13.0
  • bitsandbytes version: not installed
  • DeepSpeed version: not installed
  • Diffusers version: not installed
  • Liger-Kernel version: 0.5.2
  • LLM-Blender version: not installed
  • OpenAI version: not installed
  • PEFT version: not installed

Checklist

  • I have checked that my issue isn't already filed (see open issues)
  • I have included my system information
  • Any code provided is minimal, complete, and reproducible (more on MREs)
  • Any code provided is properly formatted in code blocks, (no screenshot, more on code blocks)
  • Any traceback provided is complete

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions