Move _get_kl_completion_ids into _get_kl_dataset#6181
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
albertvillanova
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_get_kl_completion_idswas a module-level helper used in exactly one place. Move it into its only caller,KTOTrainer._get_kl_dataset, as a nested function, alongside the existingrename_kl_fn.The direct unit test that imported the helper is removed; its behavior stays covered through the trainer's KL-dataset preparation.
Note
Low Risk
Refactor-only with no API or algorithm change; only test coverage for the helper moved from a unit test to trainer integration paths.
Overview
Inlines the KL mismatching logic that used to live in module-level
_get_kl_completion_idsintoKTOTrainer._get_kl_datasetas a nestedget_kl_completion_ids, next torename_kl_fn. The batcheddataset.mapcall now uses that nested function; behavior (cyclingcompletion_idsby +1 within each batch for the KL term) is unchanged.Test cleanup drops the direct import and the synthetic
Datasetblock intest_tokenize_and_process_tokensthat exercised the old public helper. A comment in the vision collator is updated to referenceget_kl_completion_idsinstead of the removed name.Reviewed by Cursor Bugbot for commit ac09b1d. Bugbot is set up for automated code reviews on this repo. Configure here.