Fix KTOTrainer._prepare_dataset type hint#6207
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
changed the title
albertvillanova
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic type hint fix.
Note
Low Risk
Annotation-only change with no behavioral impact.
Overview
Tightens the
argsparameter onKTOTrainer._prepare_datasetfromKTOConfig | NonetoKTOConfig, matching how the method is always called (withargsorself.argsafter__init__has already replaced a missing config with a default).No runtime logic changes—type checking and documentation only.
Reviewed by Cursor Bugbot for commit ee22434. Bugbot is set up for automated code reviews on this repo. Configure here.