Align KTO with DPO: Align Liger loss naming#6244
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
…-loss-name-fu-6243
kashif
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align KTO with DPO: Align Liger loss naming.
Follow-up to:
Part of:
This PR refactors the naming of the Liger loss function attribute in the
KTOTrainerclass to improve code clarity and consistency. The main change is renaming the attribute fromliger_loss_fntoliger_lossand updating its usage accordingly.Changes
Refactoring for clarity:
liger_loss_fntoliger_lossin theKTOTrainerclass constructor (__init__) for clearer and more consistent naming.liger_lossinstead ofliger_loss_fnin the_compute_loss_ligermethod.Note
Low Risk
Identifier rename only; no logic, API, or training behavior changes.
Overview
Renames the Liger fused KTO loss attribute on
KTOTrainerfromliger_loss_fntoliger_loss, and updates the call site in_compute_loss_ligerto match. This is a naming-only change so KTO follows the same convention as DPO after #6243; behavior is unchanged.Reviewed by Cursor Bugbot for commit aba91ad. Bugbot is set up for automated code reviews on this repo. Configure here.