Align Liger loss naming across experimental trainers#6245
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align Liger loss naming across experimental trainers.
Follow-up to:
This PR standardizes the naming of the Liger loss instance variable across multiple experimental trainer classes. The variable previously named
liger_jsd_lossis now consistently renamed toliger_losswherever it is initialized and used. This improves code clarity and consistency across the codebase.Changes
Variable renaming for consistency:
Renamed the
liger_jsd_lossinstance variable toliger_lossin the constructors of the following trainer classes:DistillationTrainer,GKDTrainer,GOLDTrainer,SDFTTrainer, andSDPOTrainer(trl/experimental/distillation/distillation_trainer.py,trl/experimental/gkd/gkd_trainer.py,trl/experimental/gold/gold_trainer.py,trl/experimental/sdft/sdft_trainer.py,trl/experimental/sdpo/sdpo_trainer.py).Updated all usages of the renamed variable from
self.liger_jsd_losstoself.liger_lossin the corresponding loss computation methods in each trainer.Note
Low Risk
Identifier-only refactor with no training or loss behavior changes.
Overview
Renames the fused Liger JSD loss instance from
liger_jsd_losstoliger_lossin five experimental trainers:DistillationTrainer,GKDTrainer,GOLDTrainer,SDFTTrainer, andSDPOTrainer.Initialization and loss forward calls are updated in each file;
LigerFusedLinearJSDLossconstruction and arguments are unchanged. This aligns naming with follow-up to #6243 so the attribute name is consistent across distillation-style trainers.Reviewed by Cursor Bugbot for commit 416fbd2. Bugbot is set up for automated code reviews on this repo. Configure here.