Align KTO with DPO: Align F import with the rest of the repo#6246
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
kashif
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the effort to align
KTOTrainer(experimental) withDPOTrainer. (#4786)kto_trainer.pywas the only file usingfrom torch.nn import functional as F. Switched it toimport torch.nn.functional as F, which is the convention used everywhere else (22 files). Import block now matchesdpo_trainer.py.No behavior change.
Note
Low Risk
Single-file import reorder with no logic or API changes.
Overview
As part of aligning experimental
KTOTrainerwithDPOTrainer,kto_trainer.pynow importsFthe same way as the rest of TRL:import torch.nn.functional as Fnext toimport torch, instead offrom torch.nn import functional as Flower in the import block.This is import-only;
F.sigmoidusage in KTO loss paths is unchanged.Reviewed by Cursor Bugbot for commit 747eb82. Bugbot is set up for automated code reviews on this repo. Configure here.