Align KTO with DPO: Align error for Liger with precompute_ref_logps#6270
Merged
albertvillanova merged 2 commits intoJul 3, 2026
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
…-liger-precompute_ref_logps
qgallouedec
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align KTO with DPO: Align error for Liger with precompute_ref_logps.
Part of:
This PR makes a small update to the error message in the
__init__method ofKTOTrainerto clarify the usage restrictions when using the Liger KTO loss withprecompute_ref_logps, aligned withDPOTrainer.Changes
precompute_ref_log_probsor settinguse_liger_kernelto False.Note
Low Risk
Copy-only change to an initialization error message; no training or runtime logic is modified.
Overview
Updates the
ValueErrorraised inKTOTrainer.__init__whenuse_liger_kernel=Trueandprecompute_ref_log_probs=Trueare used together.The message now states that Liger KTO loss does not support precomputing reference log probabilities, and tells users to either turn off
precompute_ref_log_probsor setuse_liger_kerneltoFalse—matchingDPOTrainer’s wording for the same incompatible combination. Validation behavior is unchanged.Reviewed by Cursor Bugbot for commit 47da402. Bugbot is set up for automated code reviews on this repo. Configure here.