[Job Launcher] fix: accept unknown manifest as is - #3984
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 5 Skipped Deployments
|
Dzeranov
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
N/A
Context behind the change
When using
manifest-quick-launchit's assumed thatmanifestis passed as is in request body, but at the same time our application has interceptor to transform snake case props to camel case. Described behavior affects manifest as well so it is not correct for downstream oracles. So we need to keep onlymanifestprops as is (it can be not just snake case but any naming) and also preserve validation of other fields in body, introduced a decorator that allows skipping specific body props for case transformation.How has this been tested?
manifestwith a mix of various cases and namings, make sure it's logged as is in controller before business logic is calledRelease plan
Just merge
Potential risks; What to monitor; Rollback plan
Should be none