[3.x] Support pages with more output file extensions (Sitemap inclusion policy)#2528
Merged
emmadesilva merged 8 commits intoJul 13, 2026
Merged
Conversation
Replaces the instanceof Redirect filter in SitemapGenerator with a HydePage::showInSitemap() method backed by the sitemap front matter key, defaulting to false for pages whose resolved output path is not HTML. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…indexes Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
(bool) cast treated quoted string values like "false" as truthy, silently including pages meant to be excluded from the sitemap. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2b6034a to
db53aae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed:
Tests: testShowInSitemap joined the BaseHydePageUnitTest contract and all six page unit tests. Two existing tests asserted the leak as expected behavior and were flipped: SitemapServiceTest now asserts the docs search page stays while the search index is excluded, and SitemapFeatureTest's expected XML dropped its docs/search.json entry and gained a sitemap: false page exercised through the real build:sitemap command. NonHtmlPageOutputTest got an end-to-end guard: a registered robots.txt page built by the real build command is asserted absent from the built sitemap — the exact regression the D3 note warns about.
Docs: Release notes in HYDEPHP_V3_PLANNING.md cover the new feature and the bugfix; the epic's D3 and PR 4 sections are marked ✅ Implemented with notes. No UPGRADE.md entry — the fix requires no user action, and nothing realistic depended on search indexes appearing in sitemaps.