[3.x] Rename terminal block formatting flag to usesFormatting - #2578
Merged
Conversation
The flag toggles whether formatter tags are parsed at all; it isn't specific to Symfony, so usesSymfonyFormatting was a misleading name for an internal property.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2578 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1782 1782
===========================================
Files 184 184
Lines 4422 4422
===========================================
Hits 4422 4422 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The xml modifier's four formatter tags happen to match Symfony Console's, but calling them out by name ties the docs to that styling choice. Describe them as XML style formatting instead, so the tag set can change independently of Symfony's.
emmadesilva
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TerminalBlockViewModel::$usesSymfonyFormattingproperty (and corresponding constructor argument / parser method) tousesFormatting, since the flag isn't specific to Symfony.Test plan
vendor/bin/pest --filter="TerminalBlockViewModel|TerminalCodeBlocks"passes (56 tests, 112 assertions)