fix(app): clear VirtualMultiSelect search input on select/add#2676
Conversation
🦋 Changeset detectedLatest commit: 8475f88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile SummaryThis PR clears the virtual multi-select search box after a value is chosen. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (4): Last reviewed commit: "Merge branch 'main' into cursor/clear-vi..." | Re-trigger Greptile |
E2E Test Results✅ All tests passed • 238 passed • 1 skipped • 1067s
Tests ran across 4 shards in parallel. |
3563ebf to
88af915
Compare
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Deep Review✅ No critical issues found. This is a one-line change: 🟡 P2 — recommended
🔵 P3 nitpicks (1)
Reviewers (7): correctness, testing, maintainability, project-standards, kieran-typescript, julik-frontend-races, agent-native. Testing gaps:
|
Why
Previously, when a user typed a search value into the
VirtualMultiSelectand then added it as a value, the typed text was left behind in the input. This diverges from the behavior of a non-virtualized MantineMultiSelectwith search, which clears the input after a value is selected.This has been requested by at least 3 independent users.
Before
Screen.Recording.2026-07-22.at.12.43.26.PM.mov
After
Screen.Recording.2026-07-22.at.12.43.01.PM.mov
Testing
This can be tested in the preview environment by creating a dashboard filter and searching for + selecting a value.
Closes HDX-4816