chore: Commit automatic lint fixes

[pulpdrew]

Summary

This PR commits the results of running make dev-lint after a lint rule was previously added to the ignore list for test files. This PR also reduces the limit on lint warnings in the app to the current number, after these fixes.

Screenshots or video

How to test on Vercel preview

N/A - no behavior changes

References

• Linear Issue:
• Related PRs:

[changeset-bot]

⚠️ No Changeset found

Latest commit: e9fe093

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
hyperdx-oss	Ignored	Preview	Aug 5, 2026 8:06pm
hyperdx-storybook	Ignored	Preview	Aug 5, 2026 8:06pm

[github-actions]

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

• Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats

• Production files changed: 1
• Production lines changed: 2 (+ 30 in test files, excluded from tier calculation)
• Branch: drew/run-lint-fix
• Author: pulpdrew

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

[github-actions]

E2E Test Results

✅ All tests passed • 269 passed • 1 skipped • 1094s

Status	Count
✅ Passed	269
❌ Failed	0
⚠️ Flaky	1
⏭️ Skipped	1

Tests ran across 4 shards in parallel.

View full report →

[greptile-apps]

Greptile Summary

This PR applies automatic lint cleanup to frontend tests and lowers the app’s accepted ESLint warning count to the current baseline.

• Removes obsolete @eslint-react/no-unnecessary-use-prefix suppression comments from Jest mocks.
• Reduces packages/app lint’s --max-warnings limit from 740 to 663.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
packages/app/package.json	Lowers the ESLint warning ceiling from 740 to 663 without changing runtime dependencies or application behavior.
packages/app/src/tests/SessionSidePanel.test.tsx	Removes an obsolete lint-suppression comment from the nuqs test mock.
packages/app/src/components/tests/DBRowSidePanel.missingSource.test.tsx	Removes an obsolete lint-suppression comment from the useQueryState mock.
packages/app/src/components/tests/DBRowSidePanel.rememberedTab.test.tsx	Removes obsolete lint-suppression comments from mocked hooks without altering test behavior.
packages/app/src/components/tests/DBRowSidePanel.spanLinks.test.tsx	Removes obsolete lint-suppression comments from mocked hooks without altering test behavior.
packages/app/src/components/tests/DBRowSidePanel.spanLinksBreadcrumb.test.tsx	Removes obsolete lint-suppression comments from mocked hooks without altering test behavior.
packages/app/src/components/tests/DBRowSidePanel.staleStack.test.tsx	Removes an obsolete lint-suppression comment from the useQueryState mock.
packages/app/src/hooks/tests/useDashboardKioskMode.test.tsx	Removes an obsolete lint-suppression comment from the useQueryState mock.
packages/app/src/hooks/tests/useSidePanelStack.test.tsx	Removes an obsolete lint-suppression comment from the useQueryState mock.

_{Reviews (2): Last reviewed commit: "Merge branch 'main' into drew/run-lint-f..." | Re-trigger Greptile}

[github-actions]

<!-- deep-review -->

Deep Review

⚠️ Review did not run — diff unavailable in this environment

The multi-agent review could not be dispatched. Every path to the PR diff failed:

• Bash is non-functional. All commands — including pwd — fail at the sandbox layer with bwrap: Can't create file at /home/.mcp.json: Permission denied, both sandboxed and with the sandbox disabled. git diff, git log, and gh pr diff never execute. Two independent sub-agents reproduced the identical failure.
• WebFetch is not permitted, so patch-diff.githubusercontent.com/raw/hyperdxio/hyperdx/pull/2819.diff could not be retrieved as a fallback.
• Grep/Glob were unavailable to the delegated agent, leaving Read as the only working file tool.

Without a diff, no finding can be attributed to this change, and every severity level in the grading rubric requires a failure mode introduced by this diff. Reporting findings derived from whole-file reads of an unknown changed-file set would produce unattributable noise, so no persona reviewers were dispatched. No conclusions about this PR's correctness should be drawn from this comment — treat the review as not performed, not as passed.

🟡 P2 — recommended

The following was verified by direct file reads of the checked-out tree. It is germane to this PR's stated mechanism but could not be confirmed as introduced by this diff, and may be pre-existing.

• packages/cli/package.json:36 — make dev-lint runs nx run-many -t lint:fix, but packages/cli defines only a lint script and no lint:fix target, so Nx silently skips the package while make ci-lint still enforces its --max-warnings 9 ceiling in CI.
  • Fix: Add a lint:fix script to packages/cli/package.json mirroring the other packages so the fix sweep and the CI gate cover the same set of projects.

🔵 P3 nitpicks (1)

• packages/api/eslint.config.mjs:45 — @typescript-eslint/no-unsafe-type-assertion is set to warn repo-wide in api, absorbing test-only assertion noise into the package's warning budget, whereas common-utils keeps the rule at error and scopes an off override to test globs only.
  • Fix: Set the rule to error in packages/api/eslint.config.mjs and add a test-glob override matching the common-utils pattern.

---

Reviewers (0): none dispatched — diff scope could not be resolved (Bash broken, WebFetch unpermitted).

Testing gaps:

• The claim that each --max-warnings ceiling equals the post-fix warning count could not be verified, since ESLint cannot be executed without Bash.
• The warning ceilings are hardcoded per package (app 663, api 357, common-utils 92, cli 9, hdx-eval 3) with no mechanism to auto-tighten them as warnings are resolved, so the ratchet depends entirely on manual follow-up PRs like this one.

To get a real review: re-run once the bwrap sandbox failure is resolved, or grant WebFetch access to patch-diff.githubusercontent.com so the diff can be fetched over the network.

[github-actions]

<!-- deep-review -->

Deep Review

⚠️ Review could not be executed — no findings were produced.

The multi-agent review was dispatched but could not reach Stage 1 (scope detection). The diff for this PR was never read, so this comment asserts nothing about the correctness of the change. Treat it as a tooling failure report, not as a clean bill of health.

What blocked it

• Bash is unavailable. Every invocation — including a bare true — fails at sandbox bootstrap with bwrap: Can't create file at /home/.mcp.json: Permission denied. The failure persists with the sandbox override disabled, so it is a wrapper-level problem, not a policy one. This kills git diff, git log, git merge-base, and gh.
• No filesystem search tools. Grep and Glob are not present in this session (confirmed via ToolSearch), and sub-agents report the same gap despite their declared toolsets. Read on a directory returns EISDIR, so the changed-file list cannot be enumerated by hand either.
• WebFetch permission was not granted, closing the fallback of pulling the file list from the GitHub API.
• No pre-computed diff artifact exists on disk. .git/MERGE_MSG, .git/COMMIT_EDITMSG, and .git/ORIG_HEAD are absent; .git/logs/HEAD and .git/packed-refs contain only ref→SHA mappings.

Confirmed repository state, for whoever re-runs this: HEAD is e9fe093746d9f288bab03243d30b9aacad0e8907 on drew/run-lint-fix, and refs/remotes/origin/main is 7779d2b265c9cfccf8a8ff9054f00c9963c41601 — matching the requested base. The base is reachable; only the ability to diff against it is missing.

What a re-run should target

Not findings — these are the areas left uncovered, listed so the next pass is not starting cold. An automated eslint --fix sweep is low-risk per-hunk but not uniformly behavior-preserving, and the rules enabled in packages/app/eslint.config.mjs include several whose autofixes can change runtime semantics:

• react-hooks/exhaustive-deps is set to error at packages/app/eslint.config.mjs:130; dependency-array autofixes change effect re-run frequency and are the highest-value hunks to read individually.
• simple-import-sort/imports at packages/app/eslint.config.mjs:163 reorders imports, which can change module side-effect ordering.
• @typescript-eslint/no-unused-vars at packages/app/eslint.config.mjs:155 — verify that removals did not drop bindings referenced only from type positions.
• The --max-warnings ratchet at packages/app/package.json:17 currently reads 663. Whether that number matches the post-fix warning count is not verifiable without running the linter, and the pre-PR value is not visible without the diff. Confirm the value is exact rather than approximate, since ci:lint (packages/app/package.json:20) gates on it.

How to unblock

Re-dispatch once Bash is functional, or grant WebFetch so the file list and patches can be pulled from the GitHub API. Both paths recover full scope detection; no other stage of the review pipeline was reached.

---

Reviewers (0): none — all reviewer sub-agents were withheld because no diff could be supplied to them. Dispatching them against an unreadable scope would have produced unfounded findings.

Testing gaps: not assessed — requires the diff.