Fix invalid @test message call in e2e_test.jl - #29
Merged
Conversation
Julia's `@test` does not accept a fail-message argument, so `@test (cond) "Key $key ..."` raised "invalid test macro call" at macro-expansion time, aborting the entire E2E suite before any assertion ran. Compute the serialisability predicate, emit an informative @warn naming the offending key/type on failure, then assert the predicate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
hyperpolymath
added a commit
that referenced
this pull request
Jul 10, 2026
…lity assertion) (#31) With the malformed `@test` macro fixed in #29, the E2E suite now actually runs its "report is JSON-serialisable" assertion — and catches a latent bug: `descriptive_stats` returned `outlier_fences` as a `Tuple{Float64,Float64}`, but the report contract only allows Number/String/Bool/Nothing/**Vector**. Emit `[lower, upper]` as a `Vector` so the value round-trips as a JSON array. No consumer indexes it tuple-specifically (repo-wide grep). This is the last known-red piece of the E2E suite on `main`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/e2e_test.jl:112used@test (cond) "message", but Julia's@testmacro does not accept a fail-message argument — this raised "invalid test macro call" at macro-expansion time, aborting the entire E2E suite before any assertion executed. Pre-existing onmain; surfaced while finishing the rename.Fix: compute the serialisability predicate,
@warnwith the offendingkey/type on failure (preserving the original diagnostic), then@testthe predicate.🤖 Generated with Claude Code