Return outlier_fences as a Vector, not a Tuple (fixes E2E serialisability assertion) - #31
Merged
Merged
Conversation
descriptive_stats' report is contractually JSON-serialisable
(Number/String/Bool/Nothing/Vector), but "outlier_fences" was a
Tuple{Float64,Float64}. The e2e serialisability assertion never
caught it because the malformed @test macro aborted the file before
that check ran; with the macro fixed, the suite now flags it.
Emit [lower, upper] as a Vector so the value round-trips as a JSON
array. No consumer indexes it tuple-specifically.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the malformed
@testmacro fixed in #29, the E2E suite now actually runs its "report is JSON-serialisable" assertion — and catches a latent bug:descriptive_statsreturnedoutlier_fencesas aTuple{Float64,Float64}, but the report contract only allows Number/String/Bool/Nothing/Vector.Emit
[lower, upper]as aVectorso the value round-trips as a JSON array. No consumer indexes it tuple-specifically (repo-wide grep). This is the last known-red piece of the E2E suite onmain.🤖 Generated with Claude Code