Fake fullscreen toggle not working

[nawfalmrouyan]

hl.bind(
	mainMod .. " + SHIFT + F",
	hl.dsp.window.fullscreen_state({ internal = 1, client = 2, action = "toggle" }),
	{ description = "Fake Fullscreen focused window" }
)
hl.window_rule({ border_size = 0, match = { fullscreen_state_internal = 1, fullscreen_state_client = 2 } })

When I toggle a window into fake fullscreen, it should maximize and set border=0. This no longer works as before. Now, the window maximizes but the border is still showing. The window rule no longer matches, and toggling fake fullscreen again also does not restore the window to its previous width.

I track hyprland-git on Arch daily, and the issue started today after the “manually handle fullscreen in scrolling layout” merge.

[nawfalmrouyan]

After using the bind, I noticed that YouTube videos only enter fullscreen within the client window, which perhaps the toggle doesn't work. I have to manually set the internal state to 2 to make the window fully fullscreen.

[MightyPlaza]

There used to be warning in the wiki that using fullscreen_state would set sync_fullscreen to False, and you'd have to change it (to True) manually
But looking at the code it should set it to True if toggled to 0 0

[nawfalmrouyan]

The window rule works when setting internal value to 0.

hl.window_rule({ border_size = 0, match = { fullscreen_state_internal = 0, fullscreen_state_client = 2 } })

I guess the internal state is a bit wonky in scrolling layout? Calling internal = 1 maximizes the window, but it doesn't set the internal to 1 hence the window rule failed. Ultimately, toggle also failed since internal is already 0.

[nawfalmrouyan]

Looks like maximize isn't implemented in scrolling layout.

#14380

[Tobs2007]

i noticed something similar here, when i fullscreen a window, it does go fullscreen successfully. but when i exit fullscreen, the gaps stay at 0. this state also emerges from grabbing a window of my other monitor and dropping it onto the other quickly. if i do it slowly, the gaps work correctly.

[tekstryder]

but when i exit fullscreen, the gaps stay at 0

Yes. Assuming you're on today's commits... see #14363 for repro.

[tekstryder]

@Tobs2007 , I've verified this part is fixed with commit 8b78de5.