Add SOLOGOODF722 target (with config.c for PINIO user boxes)#11689
Merged
sensei-hacker merged 3 commits intoJul 6, 2026
Conversation
Sets the target's two PINIO pins as user-assignable boxes (BOX_PERMANENT_ID_USER1/2) via targetConfiguration(), per review request on upstream PR iNavFlight#11394.
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Closed
|
Test firmware build ready — commit Download firmware for PR #11689 242 targets built. Find your board's
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finishes #11394 (adds the SOLOGOODF722 flight controller target) by adding the
config.cfile requested in review but never supplied by the original PR author.Credit for the target and flash chip support goes entirely to the author of
#11394 (Valerii Chebanov) — the 3 commits here are cherry-picked unchanged
from that PR. This PR adds one new commit on top:
config.c, persensei-hacker's 2026-05-18 review comment on #11394 asking for the target's
two PINIO pins to be made available as user-assignable boxes.
Changes
src/main/drivers/flash_m25p16.c— corrects the label on the existing0x856018JEDEC ID entry (was mislabeled "PY25Q128HA", now "PY25Q128H")and adds the actual PY25Q128HA entry (
0x852018) used by this target'sflash chip. (From SOLOGOODF722 target #11394.)
src/main/target/SOLOGOODF722/{CMakeLists.txt,target.c,target.h}— newhardware target. (From SOLOGOODF722 target #11394.)
src/main/target/SOLOGOODF722/config.c— new. ImplementstargetConfiguration()to assign the target's two PINIO pins toBOX_PERMANENT_ID_USER1/USER2, matching the pattern used by othertargets (e.g.
AOCODARCH7DUAL).Testing
SOLOGOODF722target successfully (RelWithDebInfo): no compileror linker errors/warnings. Flash usage ~467KB, RAM ~129KB, no overflow.
config.c'spinioBoxConfigMutable()andBOX_PERMANENT_ID_USER1/2resolve correctly viaio/piniobox.handfc/fc_msp_box.h.target.cmap to distinctDMA controller/stream pairs (no DMA contention), including the
dmaopt=1override needed to avoid a DMA2 Stream6 collision betweenTIM1_CH1 and TIM1_CH2.