Skip to content

Add SOLOGOODF722 target (with config.c for PINIO user boxes)#11689

Merged
sensei-hacker merged 3 commits into
iNavFlight:release/9.1from
sensei-hacker:sologoodf722-target-91
Jul 6, 2026
Merged

Add SOLOGOODF722 target (with config.c for PINIO user boxes)#11689
sensei-hacker merged 3 commits into
iNavFlight:release/9.1from
sensei-hacker:sologoodf722-target-91

Conversation

@sensei-hacker

@sensei-hacker sensei-hacker commented Jul 6, 2026

Copy link
Copy Markdown
Member

Summary

Finishes #11394 (adds the SOLOGOODF722 flight controller target) by adding the
config.c file requested in review but never supplied by the original PR author.

Credit for the target and flash chip support goes entirely to the author of
#11394 (Valerii Chebanov) — the 3 commits here are cherry-picked unchanged
from that PR. This PR adds one new commit on top: config.c, per
sensei-hacker's 2026-05-18 review comment on #11394 asking for the target's
two PINIO pins to be made available as user-assignable boxes.

Changes

  • src/main/drivers/flash_m25p16.c — corrects the label on the existing
    0x856018 JEDEC ID entry (was mislabeled "PY25Q128HA", now "PY25Q128H")
    and adds the actual PY25Q128HA entry (0x852018) used by this target's
    flash chip. (From SOLOGOODF722 target #11394.)
  • src/main/target/SOLOGOODF722/{CMakeLists.txt,target.c,target.h} — new
    hardware target. (From SOLOGOODF722 target #11394.)
  • src/main/target/SOLOGOODF722/config.c — new. Implements
    targetConfiguration() to assign the target's two PINIO pins to
    BOX_PERMANENT_ID_USER1/USER2, matching the pattern used by other
    targets (e.g. AOCODARCH7DUAL).

Testing

  • Built the SOLOGOODF722 target successfully (RelWithDebInfo): no compiler
    or linker errors/warnings. Flash usage ~467KB, RAM ~129KB, no overflow.
  • Verified config.c's pinioBoxConfigMutable() and
    BOX_PERMANENT_ID_USER1/2 resolve correctly via io/piniobox.h and
    fc/fc_msp_box.h.
  • Verified all motor/LED timer channels in target.c map to distinct
    DMA controller/stream pairs (no DMA contention), including the
    dmaopt=1 override needed to avoid a DMA2 Stream6 collision between
    TIM1_CH1 and TIM1_CH2.

valeriyc and others added 3 commits July 5, 2026 21:01
Sets the target's two PINIO pins as user-assignable boxes (BOX_PERMANENT_ID_USER1/2)
via targetConfiguration(), per review request on upstream PR iNavFlight#11394.
@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@sensei-hacker sensei-hacker added the New target This PR adds a new target label Jul 6, 2026
@sensei-hacker sensei-hacker added this to the 9.1 milestone Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Test firmware build ready — commit 2197875

Download firmware for PR #11689

242 targets built. Find your board's .hex file by name on that page (e.g. MATEKF405SE.hex). Files are individually downloadable — no GitHub login required.

Development build for testing only. Use Full Chip Erase when flashing.

@sensei-hacker sensei-hacker merged commit e5a84ed into iNavFlight:release/9.1 Jul 6, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New target This PR adds a new target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants