Fix LED strip / ADC1 DMA conflict on DAKEFPVH743PRO#11696
Merged
sensei-hacker merged 1 commit intoJul 7, 2026
Merged
Conversation
TIM3 CH3 (LED strip) was assigned DMA option 8 (DMA2 Stream0), the same stream ADC1 uses for VBAT/current sensing, causing DMA contention between the two peripherals. Move the LED strip to DMA option 9 (DMA2 Stream1), which is unclaimed on this target, matching the fix already applied to the sibling DAKEFPVH743_SLIM target. Verified on physical hardware: LED strip, VBAT, and current sensing all work correctly with DSHOT and the LED strip active simultaneously.
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Test firmware build ready — commit Download firmware for PR #11696 1 targets built. Find your board's
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a DMA stream conflict between the LED strip and ADC1 (VBAT/current sensing) on DAKEFPVH743PRO.
Problem
TIM3 CH3(LED strip) was assigned DMA option 8, which resolves to DMA2 Stream0 on STM32H743. ADC1 (used here for VBAT and current-meter sensing) is hardwired to the same DMA2 Stream0 in the driver. Driving the LED strip and reading VBAT/current at the same time contended for the same DMA stream.Changes
src/main/target/DAKEFPVH743PRO/target.c: LED strip DMA option changed from 8 (DMA2 Stream0) to 9 (DMA2 Stream1), which is unclaimed on this target since ADC2/ADC3 are never enabled here.This matches the identical fix already merged for the sibling
DAKEFPVH743_SLIMtarget, and the pattern used by several other STM32H7 targets (MATEKH743, FOXEERH743, BLUEBERRYH743, etc.) that route the LED strip off DMA2 Stream0 for the same reason.Testing