You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR backports 5.0 configuration to 4.6. 4.6 branch is already available for ibexa/rector package.
Ibexa 5.0 set contains deprecations that should be removed in 4.6 anyway.
There might be some minor differences (like we deprecated something in 5.0 only). We could approach that in several ways:
Keep different contents of 5.0 set list between 4.6 and 5.0 branches in ibexa/rector package,
Keep a copy of the 5.0 set as the 4.6 set with changes, ✔️ chosen solution
Ensure all 5.0 rules are executable on 4.6.
Update Jan 28: after today's dry run for the presentation the conclusion was that having IBEXA_46 set would look less confusing in case of 4.6.
Update Mar 12: changed PR to use IbexaSetList::IBEXA_46 set for 4.6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This PR backports
5.0configuration to4.6.4.6branch is already available foribexa/rectorpackage.Ibexa 5.0 set contains deprecations that should be removed in 4.6 anyway.
There might be some minor differences (like we deprecated something in 5.0 only). We could approach that in several ways:
Keep different contents of5.0set list between4.6and5.0branches inibexa/rectorpackage,5.0set as the4.6set with changes, ✔️ chosen solutionEnsure all5.0rules are executable on4.6.Update Jan 28: after today's dry run for the presentation the conclusion was that having
IBEXA_46set would look less confusing in case of 4.6.Update Mar 12: changed PR to use
IbexaSetList::IBEXA_46set for 4.6.