Skip to content

[ibexa/rector] Backported Ibexa Rector recipe to 4.6 - #152

Merged
alongosz merged 1 commit into
masterfrom
backport-rector-to-4.6
Mar 13, 2025
Merged

[ibexa/rector] Backported Ibexa Rector recipe to 4.6#152
alongosz merged 1 commit into
masterfrom
backport-rector-to-4.6

Conversation

@alongosz

@alongosz alongosz commented Jan 28, 2025

Copy link
Copy Markdown
Member
🎫 Issue n/a

Related PRs:

Description:

This PR backports 5.0 configuration to 4.6. 4.6 branch is already available for ibexa/rector package.
Ibexa 5.0 set contains deprecations that should be removed in 4.6 anyway.

There might be some minor differences (like we deprecated something in 5.0 only). We could approach that in several ways:

  • Keep different contents of 5.0 set list between 4.6 and 5.0 branches in ibexa/rector package,
  • Keep a copy of the 5.0 set as the 4.6 set with changes, ✔️ chosen solution
  • Ensure all 5.0 rules are executable on 4.6.

Update Jan 28: after today's dry run for the presentation the conclusion was that having IBEXA_46 set would look less confusing in case of 4.6.

Update Mar 12: changed PR to use IbexaSetList::IBEXA_46 set for 4.6.

@github-actions

Copy link
Copy Markdown

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-152

before executing the recipes.

@sonarqubecloud

Copy link
Copy Markdown

@alongosz
alongosz requested a review from a team January 28, 2025 11:00
@alongosz alongosz changed the title [ibexa/rector] Backported Ibexa Rector to 4.6 [ibexa/rector] Backported Ibexa Rector recipe to 4.6 Jan 28, 2025
@adamwojs

adamwojs commented Feb 2, 2025

Copy link
Copy Markdown
Member

Edit: after today's dry run for the presentation the conclusion was that having IBEXA_46 set would look less confusing in case of 4.6.

Yes, please introduce dedicated set for 4.6. After the 5.0 release set will start differ from 4.6.

@alongosz
alongosz force-pushed the backport-rector-to-4.6 branch from 11e75ee to 7c51b1b Compare March 12, 2025 09:59
@sonarqubecloud

Copy link
Copy Markdown

@alongosz

Copy link
Copy Markdown
Member Author

Edit: after today's dry run for the presentation the conclusion was that having IBEXA_46 set would look less confusing in case of 4.6.

Yes, please introduce dedicated set for 4.6. After the 5.0 release set will start differ from 4.6.

Changed accordingly, requesting 2nd round of review as the solution changed.

@alongosz
alongosz requested review from a team, adamwojs and konradoboza March 13, 2025 10:53
@konradoboza
konradoboza requested a review from a team March 13, 2025 10:55
@alongosz

Copy link
Copy Markdown
Member Author

Tested with Ibexa Commerce 4.6.x-dev.

@alongosz
alongosz merged commit 11e69bc into master Mar 13, 2025
@alongosz
alongosz deleted the backport-rector-to-4.6 branch March 13, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants