Skip to content

Backported Rector Set for Ibexa 4.6 - #30

Merged
alongosz merged 17 commits into
4.6from
backport-5.0-to-4.6-set
Mar 13, 2025
Merged

Backported Rector Set for Ibexa 4.6#30
alongosz merged 17 commits into
4.6from
backport-5.0-to-4.6-set

Conversation

@alongosz

@alongosz alongosz commented Mar 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
🎫 Issue n/a

Related PRs:

Description:

To enable Partner Developers to adopt Ibexa Rector earlier and address deprecations already present in Ibexa 4.6, we've decided to introduce a Rector set specifically for version 4.6. Initially, it will be mostly a copy of the 5.0 set, but over time, the two will diverge.

The downside is of course code duplication. Do we have other ideas how to avoid it?

Backports from 5.0.x-dev (main) into 4.6 set:

@alongosz alongosz mentioned this pull request Mar 12, 2025
Merged
1 task
alongosz added 13 commits March 12, 2025 12:36
@alongosz
IBX-8531: Backported #5 to 4.6: rules for ibexa/system-info deprecations
7e9c20a
@alongosz
[Tests] Extracted Abstract for Ibexa Rector Sets test cases
82e5836
@alongosz
IBX-8535: Backported #9 for 4.6: REST related rectors
3005dd3
@alongosz
IBX-8538: Backported #10 for 4.6: FieldType configuration const
87cfd83
@alongosz
IBX-8534: Backported #11 for 4.6: SimplifiedRequest magic to strict g…
b07c012 
…etters
@alongosz
IBX-8874: Backported #13 for 4.6: Cart MoneyFactory to PC IntlMoneyFa…
f97558c 
…ctory
@alongosz
Backported #17 for 4.6: SiteFactory Configuration::TREE_ROOT const fetch
d26afc2
@alongosz
Backported #19 for 4.6: Shipping to PC RegionChoiceType and fetch ada…
8f54d8d 
…pter
@alongosz
Backported #18 for 4.6: FormBuilder Configuration::TREE_ROOT const fetch
78acf82
@alongosz
Backported #20 for 4.6: Migration Matcher::CONTENT_TYPE_IDENTIFIER co…
134b6d7 
…nst fetch
@alongosz
Backported #21 for 4.6: Solr UpdateSerializer & Field deprecations
04d2018
@alongosz
Backported #23 for 4.6: Trash SearchResult::count to totalCount property
5f4a920
@alongosz
Backported #22 for 4.6: Content SearchResult::spellSuggestion to spel…
9d5b8d9 
…lcheck property
@alongosz alongosz changed the title Prepared Rector Set for Ibexa 4.6 Backported Rector Set for Ibexa 4.6 Mar 12, 2025
@alongosz
alongosz marked this pull request as ready for review March 12, 2025 14:52
@alongosz
alongosz requested a review from a team March 13, 2025 09:18
@alongosz
alongosz force-pushed the backport-5.0-to-4.6-set branch from 54e5a60 to 11421d3 Compare March 13, 2025 10:51
konradoboza
konradoboza reviewed Mar 13, 2025
View reviewed changes
Comment thread tests/lib/Sets/Ibexa46/Fixture/rest_rename.php.inc Outdated
Comment thread tests/lib/Sets/Ibexa46/Fixture/rename_variation_interface.php.inc Outdated
Comment thread tests/lib/Sets/Ibexa46/Fixture/rest_rename.php.inc Outdated
Comment thread tests/lib/Sets/Ibexa46/Fixture/simplified_request_properties.php.inc Outdated
@konradoboza
konradoboza requested a review from a team March 13, 2025 11:09
@konradoboza
konradoboza requested a review from a team March 13, 2025 13:11
@barw4
barw4 requested a review from a team March 13, 2025 13:12
@alongosz

alongosz commented Mar 13, 2025

Copy link
Copy Markdown
Member Author

Tested with Ibexa Commerce 4.6.x-dev.

@alongosz
alongosz merged commit 42bab2c into 4.6 Mar 13, 2025
@alongosz
alongosz deleted the backport-5.0-to-4.6-set branch March 13, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barw4 barw4 barw4 approved these changes
@konradoboza konradoboza konradoboza approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alongosz @barw4 @konradoboza