Fix #1638: identify renamed yield state machine members via method impls - #3905
Merged
Conversation
Obfuscators may rename the members of compiler-generated iterator classes while keeping the MethodImpl (.override) rows intact. Since b110d5c (first shipped in ILSpy 8.0), Dispose, get_Current and GetEnumerator are identified by name or method impl; MoveNext was still looked up by name only, so such a state machine was rejected with "Method not found". The pre-Roslyn "yield break" handling likewise matched the Dispose call by name; it now compares against the already resolved Dispose handle. The new ILPretty fixture models the obfuscated shape from the issue's assemblies, against which the fix was verified; the rest of the issue was already resolved by b110d5c and 81e702f. Assisted-by: Claude:claude-fable-5:Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1638
Obfuscators may rename the members of compiler-generated iterator classes while keeping the MethodImpl (.override) rows intact. Since b110d5c (first shipped in ILSpy 8.0), Dispose, get_Current and GetEnumerator are identified by name or method impl; MoveNext was the last remaining name-only lookup, so such a state machine was rejected with "Method not found". The new ILPretty fixture models the obfuscated shape from the issue's assemblies, against which the fix was verified; the rest of the issue was already resolved by b110d5c and 81e702f.
Assisted-by: Claude:claude-fable-5:Claude Code