Keep null-conditional LINQ chains in method syntax - #3969
Open
sailro wants to merge 1 commit into
Open
Conversation
Query syntax cannot preserve a null-conditional receiver that lifts a value type. Detect null conditionals through the LINQ receiver chain before introducing query syntax. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0dd407b6-9410-48df-add5-761ca4a8dec0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr: Keep LINQ method syntax when its receiver chain contains a null-conditional access.
Fixes #3968
Problem
IntroduceQueryExpressionsonly checks the immediate LINQ receiver for?.. A chainedWhere(...).Select(...)can therefore be converted to query syntax even when its source contains a null-conditional access over a value type.The query source is then nullable and does not implement the query pattern.
Solution
Make
IsNullConditionalinspect the member and invocation receiver chain before introducing query syntax.