np.assert_allclose instead of isclose.all - #91
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates numerical-comparison assertions in the test suite by replacing np.isclose(...).all() patterns with np.testing.assert_allclose(...), improving failure reporting for array comparisons.
Changes:
- Replace
np.isclose(...).all()withnp.testing.assert_allclose(...)in multiple tests. - Add custom
err_msgstrings to preserve existing diagnostic context on failure. - Adjust relative tolerances for two spectrum-moment parameter cases (
dradii_m0,lindradii_m0).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
unit_test/test_pressure.py |
Uses np.testing.assert_allclose for ref-vs-output comparisons in test_pressure_diff. |
unit_test_debug/test_spectrum.py |
Switches to assert_allclose for bin checks and spectrum diffs; also changes eps values for two moments. |
long_test/test_timestep.py |
Switches to assert_allclose for timestep-ref comparisons in test_timestep_diff. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| f_ref = netcdf.netcdf_file(os.path.join("long_test/refdata", filename), "r") | ||
| for var in ["t", "z", "th_d", "T", "p", "r_v", "rhod"]: | ||
| assert np.isclose(f_test.variables[var][:], f_ref.variables[var][:], atol=0, rtol=eps).all(), "differs e.g. " + str(var) + "; max(ref diff) = " + str(np.where(f_ref.variables[var][:] != 0., abs((f_test.variables[var][:]-f_ref.variables[var][:])/f_ref.variables[var][:]), 0.).max()) | ||
| np.testing.assert_allclose(f_test.variables[var][:], f_ref.variables[var][:], atol=0, rtol=eps, err_msg="differs e.g. " + str(var) + "; max(ref diff) = " + str(np.where(f_ref.variables[var][:] != 0., abs((f_test.variables[var][:]-f_ref.variables[var][:])/f_ref.variables[var][:]), 0.).max())) |
Comment on lines
+67
to
69
| @pytest.mark.parametrize("mom, eps", [("wradii_m0", 1e-15), ("dradii_m0", 1e-14), | ||
| ("lindradii_m0", 1e-14), ("linwradii_m0", 1e-15), | ||
| ("wradii_m1", 7e-4), ("dradii_m1", 5e-15), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.