Add SympyToPymbolicMapperWithSymbols - #303
Merged
Merged
Conversation
alexfikl
commented
Sep 4, 2026
inducer
enabled auto-merge (rebase)
September 4, 2026 13:21
Owner
|
Thx! |
isuruf
reviewed
Sep 4, 2026
isuruf
left a comment
isuruf
left a comment
Collaborator
There was a problem hiding this comment.
We can rename Constant to NumberSymbol in symengine.py to match sympy. Then keep Constant as an alias.
Collaborator
Author
I don't feel too strongly about that. It would be nice, for sure, but there will always be some mismatch between the two. Are you making a release for symengine 0.15? 😁 |
Collaborator
Yes, probably this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed in #279 (mostly to move
piback from pymbolic).PymbolicToSympyMapperWithSymbolsalso implements a specialmap_subscript, but that can't be unambiguously roundtripped, so I left it alone.