Skip to content

PR for "Use 'prop-types' instead of React.proptypes #499"#517

Merged
skellock merged 4 commits into
infinitered:masterfrom
M-ZubairAhmed:replacing-prop-types
Sep 28, 2017
Merged

PR for "Use 'prop-types' instead of React.proptypes #499"#517
skellock merged 4 commits into
infinitered:masterfrom
M-ZubairAhmed:replacing-prop-types

Conversation

@M-ZubairAhmed

@M-ZubairAhmed M-ZubairAhmed commented Sep 28, 2017

Copy link
Copy Markdown
Contributor

Reference issue

This pull request is response to issue#499.

Raised issues

Migrate to new package prop-types from React.PropTypes.

Work done

  • Added prop-types package to the dependency.
  • Imported proptypes from that package instead of React for all the occurrences.
    • import React, { Component, PropTypes } from 'react'
      to
    • import PropTypes from 'prop-types'
  • Ran grep search across all the js files of the project to check if any import is left unchanged.

Results

  • Clean build and running
  • Although all files inside the app doesnt not depend for proptypes on react but few of the 3rd party dependencies (96 .js files) does import from React.PropTypes. Hence browser console still shows the warning.
    image

@skellock skellock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work!

@skellock skellock merged commit e855666 into infinitered:master Sep 28, 2017
@skellock skellock added this to the 1.13 milestone Nov 21, 2017
joshuayoes pushed a commit that referenced this pull request Jan 17, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Jan 27, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Jan 30, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Feb 1, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
silasjmatson pushed a commit that referenced this pull request Mar 14, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants