Converted App/Dialogs to stateless components where applicable#522
Merged
Conversation
skellock
approved these changes
Oct 4, 2017
skellock
left a comment
skellock
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Good call on the ref as function.
Contributor
Author
|
👍 |
Contributor
|
Omg, that setTimeout was nasty. Thx for the proper technique. |
Contributor
Author
|
@skellock it was pretty nasty 😜 |
| session.ui.watchToAdd = e.target.value | ||
| } | ||
|
|
||
| componentDidUpdate() { |
Contributor
There was a problem hiding this comment.
this is a really good way of doing it @ericadamski
Contributor
|
@ericadamski i learned a lot from this PR thank you |
Contributor
Author
|
@M-ZubairAhmed I am really glad! Thank you :) |
joshuayoes
pushed a commit
that referenced
this pull request
Jan 17, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes
pushed a commit
that referenced
this pull request
Jan 27, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes
pushed a commit
that referenced
this pull request
Jan 30, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes
pushed a commit
that referenced
this pull request
Feb 1, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
silasjmatson
pushed a commit
that referenced
this pull request
Mar 14, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #518
Also update some of the
setTimeout(() => ReactDOM.findDOMNode(...), 1)calls to use React lifecycle methods and ref functions rather than string references.