Skip to content

Add OVHcloud as new cloud provisioner#10

Merged
alexellis merged 1 commit intoinlets:masterfrom
dirien:ovh
Jul 29, 2021
Merged

Add OVHcloud as new cloud provisioner#10
alexellis merged 1 commit intoinlets:masterfrom
dirien:ovh

Conversation

@dirien
Copy link
Contributor

@dirien dirien commented Jul 22, 2021

This PR introdcue OVHcloud as new cloud provisoner for inlets*

OVH

https://www.ovh.com/

OVH, legally OVH Groupe SAS, is a French cloud computing company which offers VPS, dedicated servers and other web services. As of 2016 OVH owned the world's largest data center in surface area. As of 2019, it was the largest hosting provider in Europe, and the third largest in the world based on physical servers.[1]

Signed-off-by: Engin Diri engin.diri@mail.schwarz

[1] https://en.wikipedia.org/wiki/OVHcloud

@derek derek bot added the no-dco label Jul 22, 2021
@derek
Copy link

derek bot commented Jul 22, 2021

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot removed the no-dco label Jul 22, 2021
@dirien dirien changed the title Add OVHCloud as new cloud provisioner Add OVHcloud as new cloud provisioner Jul 22, 2021
@alexellis
Copy link
Member

👍

What's the cheapest plan they offer?

And can you rebase please?

Signed-off-by: Engin Diri <engin.diri@mail.schwarz>
@dirien
Copy link
Contributor Author

dirien commented Jul 27, 2021

Done.
2.99EUR ext VAT
image

@alexellis alexellis merged commit a67b248 into inlets:master Jul 29, 2021
@alexellis
Copy link
Member

@jsiebens
Copy link
Contributor

@dirien @alexellis fyi, deleting an instance by IP instead of ID is missing in this new provider

@dirien
Copy link
Contributor Author

dirien commented Jul 29, 2021

hi @jsiebens, thats a think i did not consider. I thought that ID is the leading identifier.

I will create a patch for this.

@jsiebens
Copy link
Contributor

The id is indeed the leading identifier, but with inletsctl you can also delete an exit node by IP. Therefore most of the providers, if not all, detect if an ID or an IP is provided in HostDeleteRequest.

@dirien
Copy link
Contributor Author

dirien commented Jul 29, 2021

@jsiebens : #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments