Add font_size to annotate_lineplot_df() - #296
Open
Melkiades wants to merge 4 commits into
Open
Conversation
Contributor
Unit Tests Summary 1 files 270 suites 3m 1s ⏱️ Results for commit 8c60457. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance DifferenceAdditional test case details
Results for commit 3a01c47 ♻️ This comment has been updated with latest results. |
Contributor
|
Code Coverage SummaryDiff against mainResults for commit: 8c60457 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
… text_size annotate_lineplot_df() had no way to set the summary table font size, so it was fixed at the df2gg_aligned() defaults. Add a font_size argument mapping to text_size and label_size, matching annotate_riskdf(). annotate_pkc_df() declared text_size but never forwarded it; wire it through.
Melkiades
force-pushed
the
295_annotate_font_size@main
branch
from
August 10, 2026 09:09
1f90834 to
f63b391
Compare
annotate_pkc_df() gains a font_size argument (points, default 10) so the whole annotate family shares one knob. The old text_size argument (geom units) is soft-deprecated via lifecycle and still honoured: it is converted to font_size so existing behaviour is preserved exactly.
The package declares Language: en-US; use 'favor' instead of 'favour'.
mhallal1
reviewed
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
annotate_lineplot_df()gains afont_sizeargument to control the summary table font size, andannotate_pkc_df()now applies itstext_sizeargument. (Control annotation table font size in annotate_lineplot_df() #295)annotate_lineplot_df()had no way to set the summary table font size, so it was fixed at thedf2gg_aligned()defaults.font_sizemaps totext_size/label_size, matchingannotate_riskdf().annotate_pkc_df()already declaredtext_sizebut never forwarded it.Reference GitHub issue associated with pull request. closes #295
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()devtools::test_coverage()