fix: corrected the config precedence for agent config#2492
Merged
aryamohanan merged 36 commits intofix-config-precedencefrom Apr 20, 2026
Merged
fix: corrected the config precedence for agent config#2492aryamohanan merged 36 commits intofix-config-precedencefrom
aryamohanan merged 36 commits intofix-config-precedencefrom
Conversation
aryamohanan
force-pushed
the
fix-config-source
branch
from
ab1d811 to
ff3b72f
Compare
aryamohanan
force-pushed
the
fix-config-source
branch
from
4ac2f6e to
3251a46
Compare
aryamohanan
force-pushed
the
fix-config-source
branch
from
0df6ffb to
87c0f80
Compare
aryamohanan
force-pushed
the
fix-config-source
branch
from
01cba30 to
cc388d0
Compare
aryamohanan
changed the title
aryamohanan
changed the title
kirrg001
reviewed
Apr 16, 2026
kirrg001
reviewed
Apr 16, 2026
kirrg001
reviewed
Apr 16, 2026
kirrg001
reviewed
Apr 16, 2026
kirrg001
reviewed
Apr 17, 2026
kirrg001
reviewed
Apr 17, 2026
kirrg001
reviewed
Apr 17, 2026
kirrg001
reviewed
Apr 20, 2026
| } | ||
|
|
||
| exports.activate = function activate(extraConfig = {}) { | ||
| exports.activate = function activate(_config = config) { |
Contributor
There was a problem hiding this comment.
Suggested change
| exports.activate = function activate(_config = config) { | |
| exports.activate = function activate(_config) { |
kirrg001
reviewed
Apr 20, 2026
kirrg001
reviewed
Apr 20, 2026
| normalizedUserConfig = {}; | ||
| } | ||
| // Clear previous sources if any | ||
| configStore.clear(); |
Contributor
There was a problem hiding this comment.
Wondering if we have to call this only on init?
Instead of // Clear previous sources if any, could you please describe why we call this here?
Contributor
Author
There was a problem hiding this comment.
We don't clear configStore on init because init() is called only once during the application lifecycle, whereas normalize() can be called multiple times (e.g., when re-normalizing configuration). The configStore.clear() call in normalize() ensures we start fresh for each normalization.
Contributor
There was a problem hiding this comment.
normalize -> resets configStore
This is not clean, but we can revisit later
Contributor
There was a problem hiding this comment.
Lets add a clear comment in the codebase here 👍
kirrg001
reviewed
Apr 20, 2026
kirrg001
reviewed
Apr 20, 2026
kirrg001
reviewed
Apr 20, 2026
kirrg001
reviewed
Apr 20, 2026
kirrg001
reviewed
Apr 20, 2026
Co-authored-by: kirrg001 <katharina.irrgang@ibm.com>
Co-authored-by: kirrg001 <katharina.irrgang@ibm.com>
Co-authored-by: kirrg001 <katharina.irrgang@ibm.com>
kirrg001
reviewed
Apr 20, 2026
kirrg001
approved these changes
Apr 20, 2026
Co-authored-by: kirrg001 <katharina.irrgang@ibm.com>
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO later