refactor(config): align disable normalizer with resolver return shape#2502
Merged
aryamohanan merged 3 commits intofix-config-precedencefrom Apr 20, 2026
Merged
refactor(config): align disable normalizer with resolver return shape#2502aryamohanan merged 3 commits intofix-config-precedencefrom
aryamohanan merged 3 commits intofix-config-precedencefrom
Conversation
aryamohanan
changed the title
30 tasks
|
kirrg001
reviewed
Apr 20, 2026
|
|
||
| if (envDisableConfig === false) { | ||
| return {}; | ||
| return { value: {}, source: CONFIG_SOURCES.ENV }; |
Contributor
Author
There was a problem hiding this comment.
This is the case when INSTANA_TRACING_DISABLE=false.
Contributor
Author
There was a problem hiding this comment.
we treat disable as object type internaly
Contributor
Author
There was a problem hiding this comment.
the external config type mixed with boolean and array obj, but internally we treat it as object.
INSTANA_TRACING_DISABLE can accept both boolean and obj array
kirrg001
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The disable normalization is currently not returning the source info
see: #2492 (comment)