feat(ui-tag): new Tag v3 implementation - #2687
Open
git-nandor wants to merge 3 commits into
Open
Conversation
Introduce a v3 of Tag (library v11_8) implementing the new design. v2 is preserved unchanged and frozen to v11_7 imports; the new ./v11_8 export and ./latest point to v3. - renderIcon leading icon that auto-sizes to the Tag size - link/button body via href/onClick, with the label and icon as one focusable group (underlined text for links) - dismissible renders a separate close button controlled by the new onDismiss callback; only the close button dismisses the tag - focus ring moved from the whole tag to the individual focusable elements (link/button body and close button) BREAKING CHANGE: Tag latest now resolves to v3. Dismissible tags are dismissed via the new onDismiss prop instead of onClick, and the focus ring appears on the close button / link body rather than the whole tag. Consumers pinned to @instructure/ui-tag/v11_7 are unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
git-nandor
changed the title
Contributor
|
Contributor
Visual regression report
Diff images (33)alert.png — baseline no longer producedavatar.png — baseline no longer producedbadge.png — baseline no longer producedbillboard.png — baseline no longer producedbreadcrumb.png — baseline no longer producedbutton-and-derivatives.png — baseline no longer producedbyline.png — baseline no longer producedcalendar.png — baseline no longer producedcheckbox.png — baseline no longer producedcheckboxgroup.png — baseline no longer producedcolorpicker.png — baseline no longer producedcontextview.png — baseline no longer producedcustom-and-lucide-icons.png — baseline no longer produceddateinput-dateinput2.png — baseline no longer produceddatetimeinput.png — baseline no longer produceddiff-demo.png — 6324 pixels differdrilldown.png — baseline no longer producedfiledrop.png — baseline no longer producedform-errors.png — baseline no longer producedheading.png — baseline no longer producedimg.png — baseline no longer producedlink.png — baseline no longer producedmenu.png — baseline no longer producedmetric-pill-tag-timeselect-text.png — baseline no longer producedoptions.png — baseline no longer producedpagination.png — baseline no longer producedprogressbar.png — baseline no longer producedselect-simpleselect.png — baseline no longer producedtable.png — baseline no longer producedtabs.png — baseline no longer producedtooltip.png — baseline no longer producedtreebrowser.png — baseline no longer producedview.png — baseline no longer producedBaselines come from the |
Add the @instructure/ui v11_8 barrel (Tag from ui-tag/v11_8, everything else still at v11_7) and register v11_8 in the docs versioned-components map so the docs render the new Tag v3 (with renderIcon/href/onDismiss). Point the umbrella ./latest at v11_8. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Use a single Tag with an icon in the README example instead of one per size. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
|
This looks PERFECT! the only thing that was missed is the color of the tag on the rebrand light theme...in that theme the tag should be the opacity navy that is used for our secondary buttons! |
Collaborator
It’s because this branch is still using v1.5.0 of the tokens. We should update it to the latest version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v3(libraryv11_8) with the new design;v2preserved and frozen to/v11_7imports.renderIconleading icon that auto-sizes to the Tagsize;href/onClickrender a focusable link/button body (underlined text for links).dismissiblenow renders a separate close button controlled by the newonDismisscallback — only the close button dismisses.src/exports/c.tsandpackage.json./v11_8+./latestpoint to v3.Test Plan
small/medium/large; link underline; focus-ring radius/height.@instructure/uiv11_8wiring and thesmall-componentsregression page update are deferred to the releasebump(umbrella/lateststill resolves Tag to v2 until then).Fixes INSTUI-5130
🤖 Generated with Claude Code