fix(ui-select,ui-text-input): show messages for non-editable selects - #2707
Open
git-nandor wants to merge 1 commit into
Open
fix(ui-select,ui-text-input): show messages for non-editable selects#2707git-nandor wants to merge 1 commit into
git-nandor wants to merge 1 commit into
Conversation
TextInput gets a `forceMessages` prop that keeps the messages visible in the readonly state, and Select sets it where it forces readonly itself. Closes: INSTUI-5172 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Contributor
Visual regression reportCypress suite: ✅ Passing Visual diff:
Accessibility (axe): ✅ No violations. 📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches. Diff images (3)select-canvas.png — 164272 pixels differselect-dark.png — 164080 pixels differselect-light.png — 164019 pixels differBaselines come from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
A Select sets its TextInput to
readonlyto hide the keyboard cursor,but the form field layer hides messages for readonly fields. Non-editable
Selects and SimpleSelects therefore rendered the error border without the message text.
Fix
TextInputv2 gets an optionalforceMessagesprop that keeps messages visible in the readonly state;Selectv2 sets it where it forces readonly itself.Test Plan
SimpleSelectwith error message and noonInputChangeshould show the message text under the input.selectpage has a newMessagesExample(Select + SimpleSelect with an error message)Fixes INSTUI-5172
🤖 Generated with Claude Code