Shared configs/workflows/default #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses spelling corrections in the "Portfolios" AI feature documentation and implements shared configuration/workflow improvements across the monorepo. The primary fix corrects "build in" to "built in" in the guardrails description for the portfolios feature.
Key changes:
- Corrects spelling error in portfolios guardrails text
- Updates package versions to 1.6.0 across affected packages
- Adds test coverage for the Layout class
- Simplifies GitHub Actions workflow configurations
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/aiinfo/src/components/portfolios/index.tsx | Corrects "build in" to "built in" in guardrails description |
| packages/aiinfo/package.json | Version bump to 1.6.0 and adds default export path |
| packages/aiinfo/cache/checksum.json | Updates checksums for CSV and portfolios data |
| packages/aiinfo/cache/cache.csv | Updates portfolios guardrails text with spelling correction |
| packages/aiinfo/Changelog.md | Documents the spelling correction in the changelog |
| package.json | Version bump to 1.6.0 for root package |
| apps/nutritionfacts/src/assets/Layout.ts | Exports Layout class alongside DefaultLayout |
| apps/nutritionfacts/src/assets/Layout.test.ts | Adds comprehensive test coverage for Layout class |
| apps/nutritionfacts/package.json | Version bump to 1.6.0 |
| .github/workflows/nutritionfacts-auto-release.yml | Fixes package installation command syntax |
| .github/workflows/deploy-apps.yml | Simplifies dependency installation process |
| run: | | ||
| set -euo pipefail | ||
| pnpm -F nutritionfacts up @instructure.ai/aiinfo@latest | ||
| pnpm -F nutritionfacts add pnpm -F nutritionfacts add "@instructure.ai/aiinfo@^${TAG#*@}" |
There was a problem hiding this comment.
The command duplicates "pnpm -F nutritionfacts add" twice, which will result in a syntax error. This should be a single command: pnpm -F nutritionfacts add "@instructure.ai/aiinfo@^${TAG#*@}"
Suggested change
| pnpm -F nutritionfacts add pnpm -F nutritionfacts add "@instructure.ai/aiinfo@^${TAG#*@}" | |
| pnpm -F nutritionfacts add "@instructure.ai/aiinfo@^${TAG#*@}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.