Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions .github/workflows/deploy-apps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,18 +54,9 @@ jobs:
if: steps.changes.outputs.skip_steps != 'true'
uses: pnpm/action-setup@v4.1.0

# ✅ NEW: configure pnpm to use registry packages, not workspace links
- name: Configure pnpm for registry install
if: steps.changes.outputs.skip_steps != 'true'
run: |
echo "link-workspace-packages=false" >> .npmrc
echo "prefer-workspace-packages=false" >> .npmrc
echo "auto-install-peers=true" >> .npmrc

- name: Install dependencies
if: steps.changes.outputs.skip_steps != 'true'
run: pnpm install --config.prefer-workspace-packages=false --link-workspace-packages=false

run: pnpm i
- name: Build
if: steps.changes.outputs.skip_steps != 'true'
run: pnpm build apps
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nutritionfacts-auto-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
shell: bash
run: |
set -euo pipefail
pnpm -F nutritionfacts up @instructure.ai/aiinfo@latest
pnpm -F nutritionfacts add pnpm -F nutritionfacts add "@instructure.ai/aiinfo@^${TAG#*@}"
Copy link

Copilot AI Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command duplicates "pnpm -F nutritionfacts add" twice, which will result in a syntax error. This should be a single command: pnpm -F nutritionfacts add "@instructure.ai/aiinfo@^${TAG#*@}"

Suggested change
pnpm -F nutritionfacts add pnpm -F nutritionfacts add "@instructure.ai/aiinfo@^${TAG#*@}"
pnpm -F nutritionfacts add "@instructure.ai/aiinfo@^${TAG#*@}"

Copilot uses AI. Check for mistakes.

- name: Commit changes (if any)
id: commit
Expand Down
2 changes: 1 addition & 1 deletion apps/nutritionfacts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@
"update-cache": "vite-node ./scripts/updateCache.mts"
},
"type": "module",
"version": "1.5.3"
"version": "1.6.0"
}
49 changes: 49 additions & 0 deletions apps/nutritionfacts/src/assets/Layout.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
import { describe, it, expect } from "vitest";
import type { PageLayout } from "../types";
import { DefaultLayout } from "./Layout";

import { Layout } from "./Layout";

describe("Layout", () => {
it("should correctly assign all true properties", () => {
const input: PageLayout = {
copyright: true,
disclaimer: true,
revision: true,
};
const layout = new Layout(input);
expect(layout.copyright).toBe(true);
expect(layout.disclaimer).toBe(true);
expect(layout.revision).toBe(true);
});

it("should correctly assign all false properties", () => {
const input: PageLayout = {
copyright: false,
disclaimer: false,
revision: false,
};
const layout = new Layout(input);
expect(layout.copyright).toBe(false);
expect(layout.disclaimer).toBe(false);
expect(layout.revision).toBe(false);
});

it("should correctly assign mixed property values", () => {
const input: PageLayout = {
copyright: true,
disclaimer: false,
revision: true,
};
const layout = new Layout(input);
expect(layout.copyright).toBe(true);
expect(layout.disclaimer).toBe(false);
expect(layout.revision).toBe(true);
});

it("DefaultLayout should have all properties true", () => {
expect(DefaultLayout.copyright).toBe(true);
expect(DefaultLayout.disclaimer).toBe(true);
expect(DefaultLayout.revision).toBe(true);
});
});
2 changes: 1 addition & 1 deletion apps/nutritionfacts/src/assets/Layout.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ const DefaultLayout = new Layout({
revision: true,
} as PageLayout);

export { DefaultLayout };
export { DefaultLayout, Layout };
10 changes: 5 additions & 5 deletions coverage/coverage.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
coverage:
totals:
statements: 2.15%
branches: 0.84%
statements: 2.12%
branches: 0.83%
functions: 3.03%
lines: 2.26%
total: 2.07%
lines: 2.23%
total: 2.05%
plugins:
totals:
statements: 33.33%
Expand Down Expand Up @@ -80,7 +80,7 @@ coverage:
branches: 0%
functions: 0%
lines: 0%
uncovered_line_numbers: "14-200"
uncovered_line_numbers: "14-218"
"test.mts":
statements: 0%
branches: 0%
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"vitest": "^3.2.4",
"yaml": "^2.8.1"
},
"version": "1.5.1",
"version": "1.6.0",
"name": "@instructure.ai/shared-configs",
"packageManager": "pnpm@10.18.3",
"private": true,
Expand Down
Loading