Skip to content

[SYCL] PR 1 - Remove FPGA attributes from SYCL FE#21710

Open
premanandrao wants to merge 2 commits intointel:syclfrom
premanandrao:remote_fpga_pr1
Open

[SYCL] PR 1 - Remove FPGA attributes from SYCL FE#21710
premanandrao wants to merge 2 commits intointel:syclfrom
premanandrao:remote_fpga_pr1

Conversation

@premanandrao
Copy link
Copy Markdown
Contributor

This removes the following attributes:

[[intel::loop_fuse]]
[[intel::loop_fuse_independent]]
[[intel::nofusion]]

@premanandrao premanandrao requested a review from a team as a code owner April 9, 2026 00:38
@premanandrao
Copy link
Copy Markdown
Contributor Author

#21102 requested that we split the large set of changes into manageable chunks. This is the first of many such chunks.

@premanandrao
Copy link
Copy Markdown
Contributor Author

The clang-formatter is pointing out changes that I did not make in this PR, so ignoring that fail.
(Code reviewers, please let me know if you do want me to make those changes as part of this PR.)

@premanandrao
Copy link
Copy Markdown
Contributor Author

Thanks @Fznamznon!

@intel/llvm-gatekeepers, this is ready for merge despite the clang-format test failure.

@premanandrao
Copy link
Copy Markdown
Contributor Author

@intel/llvm-gatekeepers, could you please merge this PR?

The clang-format failure requires me to change things beyond what I changed (it is a group of attributes) and that will make it harder to review the actual changes made in this PR. So I don't intend to, unless you strongly prefer that I do.

@againull
Copy link
Copy Markdown
Contributor

@intel/llvm-gatekeepers, could you please merge this PR?

The clang-format failure requires me to change things beyond what I changed (it is a group of attributes) and that will make it harder to review the actual changes made in this PR. So I don't intend to, unless you strongly prefer that I do.

Could you please apply clang-format. Since it will be a separate commit as only formatting change, I believe it is ok, and as far as I know we usually apply clang-format in similar situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants