Skip to content

[SYCL] Adds info query for atomic_memory_order_capabilities on device and context - #4105

Merged
bader merged 4 commits into
intel:syclfrom
steffenlarsen:steffen/memory_order_capabilities
Jul 21, 2021
Merged

[SYCL] Adds info query for atomic_memory_order_capabilities on device and context#4105
bader merged 4 commits into
intel:syclfrom
steffenlarsen:steffen/memory_order_capabilities

Conversation

@steffenlarsen

Copy link
Copy Markdown
Contributor

Implements support for device::info::atomic_memory_order_capabilities and context::info::atomic_memory_order_capabilities. The corresponding PI query is only implemented for the PI CUDA backend and host.

Additionally, these changes reverse the dependency between sycl/include/CL/sycl/ONEAPI/atomic_enums.hpp and sycl/include/CL/sycl/memory_enums.hpp and replace all uses of sycl::ONEAPI::memory_order and sycl::ONEAPI::memory_scope with sycl::memory_order and sycl::memory_scope respectively.

Comment thread sycl/include/CL/sycl/detail/pi.h Outdated
Comment thread sycl/include/CL/sycl/detail/pi.h Outdated
smaslov-intel
smaslov-intel previously approved these changes Jul 14, 2021

@smaslov-intel smaslov-intel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PI-related changes LGTM

@bader

bader commented Jul 18, 2021

Copy link
Copy Markdown
Contributor

@steffenlarsen, please, align changes with d703f57.

Steffen Larsen added 3 commits July 19, 2021 10:54
… and context

Implements support for device::info::atomic_memory_order_capabilities
and context::info::atomic_memory_order_capabilities. The corresponding
PI query is only implemented for the PI CUDA backend and host.

Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
@steffenlarsen

Copy link
Copy Markdown
Contributor Author

@steffenlarsen, please, align changes with d703f57.

I have rebased the changes. I hope this was what you wanted.

@bader
bader requested a review from smaslov-intel July 19, 2021 12:55
bader
bader previously approved these changes Jul 19, 2021
Comment thread sycl/include/CL/sycl/detail/spirv.hpp Outdated
Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
@bader

bader commented Jul 21, 2021

Copy link
Copy Markdown
Contributor

@intel/llvm-reviewers-cuda, @smaslov-intel, @intel/llvm-reviewers-runtime, ping.

@bader
bader merged commit 9b04f41 into intel:sycl Jul 21, 2021
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Jul 22, 2021
…ackend_plugin

* upstream/sycl: (26 commits)
  [SPIR-V][NFC] Move non-upstreamed FuncParam decorations into internal:: (intel#4138)
  [SYCL] Move free function queries to experimental namespace (intel#4090)
  [SYCL][XPTI] Enable PI calls notifications with arguments (intel#4148)
  [SYCL] Revert queue::wait() to its old behaviour with Level Zero (intel#4153)
  [SYCL] Add missing <cstring> header to spirv.hpp (intel#4157)
  [SYCL] Adds info query for atomic_memory_order_capabilities on device and context (intel#4105)
  [SYCL] Improve performance of generic shuffles (intel#3815)
  [SYCL] Fix the error with namespaces caused during rebase of intel#4014 (intel#4151)
  [ESIMD] Fix 'ambiguous operator' error with length 1 simd operands (intel#4149)
  [libdevice][NFC] Fix libdevice dependencies list (intel#4130)
  [SPIR-V] Reland Encode debug info producer in SPIR-V (intel#4082)
  [SYCL][ROCm] Add ROCm support to get_device_count_by_type (intel#4113)
  [SYCL] Fix sRGB device info (intel#4145)
  [SYCL][ROCm] Fix kernel launch with multiple dimensions (intel#4063)
  [SYCL][ROCm] Fix compilation for AMD GPU with -fsycl-dead-args-optimization (intel#4126)
  [SYCL][Level Zero] Enable multi-CCS support. (intel#4038)
  [SYCL] Pass bound arch to unbundler (intel#4112)
  [ESIMD][doc] Added documentation for some ESIMD math APIs (intel#3995)
  [ESIMD] rename gather4/scatter4 to gather_rgba/scatter_rgba (intel#4120)
  [SYCL][NFC] Remove unused variable. (intel#4131)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants