[NFC] Move non-upstreamed FuncParam decorations into internal:: - #4138
Conversation
Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
|
@NikitaRudenkoIntel, can we remove those |
|
Typical contribution process for llvm-spirv tool is to commit changes to Khronos repository and pull them from there. |
Modified code doesn't exists in upstream, because it does not conform to any of latest versions of our published specs and was introduced as a workaround for a VC backend to enable ESIMD feature. We didn't accept it in the translator upstream so it only landed here. I would love to get rid of it completely, but I don't know if that is possible |
"Non-upstreamed" had been my lazy attempt to highlight the nuances @AlexeySachkov has expanded above :) I'll reflect this properly in the PR description. |
…ackend_plugin * upstream/sycl: (26 commits) [SPIR-V][NFC] Move non-upstreamed FuncParam decorations into internal:: (intel#4138) [SYCL] Move free function queries to experimental namespace (intel#4090) [SYCL][XPTI] Enable PI calls notifications with arguments (intel#4148) [SYCL] Revert queue::wait() to its old behaviour with Level Zero (intel#4153) [SYCL] Add missing <cstring> header to spirv.hpp (intel#4157) [SYCL] Adds info query for atomic_memory_order_capabilities on device and context (intel#4105) [SYCL] Improve performance of generic shuffles (intel#3815) [SYCL] Fix the error with namespaces caused during rebase of intel#4014 (intel#4151) [ESIMD] Fix 'ambiguous operator' error with length 1 simd operands (intel#4149) [libdevice][NFC] Fix libdevice dependencies list (intel#4130) [SPIR-V] Reland Encode debug info producer in SPIR-V (intel#4082) [SYCL][ROCm] Add ROCm support to get_device_count_by_type (intel#4113) [SYCL] Fix sRGB device info (intel#4145) [SYCL][ROCm] Fix kernel launch with multiple dimensions (intel#4063) [SYCL][ROCm] Fix compilation for AMD GPU with -fsycl-dead-args-optimization (intel#4126) [SYCL][Level Zero] Enable multi-CCS support. (intel#4038) [SYCL] Pass bound arch to unbundler (intel#4112) [ESIMD][doc] Added documentation for some ESIMD math APIs (intel#3995) [ESIMD] rename gather4/scatter4 to gather_rgba/scatter_rgba (intel#4120) [SYCL][NFC] Remove unused variable. (intel#4131) ...
The decorations do not exist in KhronosGroup/SPIRV-LLVM-Translator, however will interfere
with the forthcoming pulldown of SPIR-V Headers changes. Therefore, the decorations should
be moved into the dedicated internal header.
Signed-off-by: Artem Gindinson artem.gindinson@intel.com