Skip to content

Add analytics to pager navigation buttons#10147

Merged
jimchamp merged 3 commits intointernetarchive:masterfrom
sbwhitt:pager-analytics
Dec 17, 2024
Merged

Add analytics to pager navigation buttons#10147
jimchamp merged 3 commits intointernetarchive:masterfrom
sbwhitt:pager-analytics

Conversation

@sbwhitt
Copy link
Collaborator

@sbwhitt sbwhitt commented Dec 13, 2024

Precedes #9742

Add analytics to the pager portion of the author search page prior to redesign. If the naming isn't quite right please let me know. I set the intermediate page links to their page numbers.

Technical

Testing

Screenshot

Stakeholders

@RayBB

@sbwhitt sbwhitt requested a review from RayBB December 13, 2024 20:24
Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion to change but otherwise this looks fantastic!

Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and looks great.

CleanShot 2024-12-17 at 12 27 16@2x

@jimchamp can you give it a final look and test that the analytics are actually working? Not sure if I can do that locally. Just not sure if having a - in the analytics is a problem.

@jimchamp jimchamp merged commit 929e0ae into internetarchive:master Dec 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants