-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
First draft for filtering logic of Global book filter #11021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
First draft for filtering logic of Global book filter #11021
Conversation
for more information, see https://pre-commit.ci
…internetarchive#11146) * Add ISFDB identifiers for authors, works, and fix HTTPS for editions
…follow-button-overflow Titles under a single line
…t-bugs Fix bugs in preference migration script
…pdate-solr Update solr to latest version, 9.9.0
…rnetarchive#11150) * allow author records with just 'death_date' to count as "dated" fixes internetarchive#10736 * refactor a has_dates() method to simplify logic * explicitly test death_date only matching for internetarchive#10736
updates: - [github.com/astral-sh/ruff-pre-commit: v0.12.9 → v0.12.10](astral-sh/ruff-pre-commit@v0.12.9...v0.12.10) - [github.com/pre-commit/mirrors-eslint: v9.33.0 → v9.34.0](pre-commit/mirrors-eslint@v9.33.0...v9.34.0)
…r/remove-ol-redirects remove old redirects
…idata-headers set headers for wikidata get request
…btn-aesthetic Remove border from ghost button styles
…list-card-corner Fixed list corner radius
…mit-ci-update-config [pre-commit.ci] pre-commit autoupdate
…te (internetarchive#11201) * Partially address internetarchive#11200, remove unused no_index compute --------- Co-authored-by: jimchamp <28732543+jimchamp@users.noreply.github.com>
…m-border Remove border from dropdown menu in language.less
* standard library imports no longer nested * remove legacy python 2 code
Scott noticed that the fields `title_sort` and `name` were appearing frequently in Solr's fieldCache and consuming a lot of space (~1.8G for `title`). He noted that the documentation recommends for things like sorting/faceting, docValues are recommended -- which solr.TextField doesn't support. But _does_ support them is the aptly names solr.SortableTextField! So we switched to that for our `title_sort` field, and for the author `name` field we switched to instead sort by `name_str` which should behave the same. Co-authored-by: Scott Barnes <scottreidbarnes@gmail.com>
* use SubjectType typehint literals * typehint literals as needed * observations type literal * add literal to schema.py * fix circular import
Scott noticed that the fields `title_sort` and `name` were appearing frequently in Solr's fieldCache and consuming a lot of space (~1.8G for `title`). He noted that the documentation recommends for things like sorting/faceting, docValues are recommended -- which solr.TextField doesn't support. But _does_ support them is the aptly names solr.SortableTextField! So we switched to that for our `title_sort` field, and for the author `name` field we switched to instead sort by `name_str` which should behave the same. Co-authored-by: Scott Barnes <scottreidbarnes@gmail.com>
for more information, see https://pre-commit.ci
|
Hi @mekarpeles and @cdrini, I’ve made updates to Carousel.js, preferences.js, preferences-handler.js, alert.html, and account.py to implement a global book filter with the following flow:
At this stage, the feature does not yet guarantee that preferences persist after a user performs a search. Oh and by the way, I'm a bit confused why there are so many changed files in this PR? |
Phase 1 of #10760
Technical:
This PR introduces the foundational logic for our global Book Preferences filter, which will live on the top IA bar. While the full feature is not yet implemented, the code in this phase is intended to do the following:
This logic allows users to set global preferences that automatically apply across all carousels, while still preserving each carousel's specific contents.
Testing:
This PR sets up the structure for the preference engine, but does not yet include unit tests. To proceed further, I would appreciate clarification on the following areas:
Looking forward to your inputs on these aspects and would be happy to build on this feature in the subsequent phases!
Stakeholders:
@mekarpeles
@cdrini