Skip to content

Conversation

@jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented Nov 6, 2025

Follows #10974

As mentioned here, the render_template call for the async reading goal progress bar was not updated after the template's file path changed. This has prevented the progress bar being displayed whenever reading goals are set.

Technical

Testing

  1. Log in
  2. Go to your "My Books" page
  3. If a goal has already been set, delete the goal by submitting 0 and refresh the page
  4. Set a new yearly reading goal
  5. Expect the progress bar to replace the "Set your 2XXX reading goal" call to action

Screenshot

Stakeholders

Copilot AI review requested due to automatic review settings November 6, 2025 00:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the template path for rendering reading goal progress components. The change corrects a misnamed template directory from check_ins/reading_goal_progress to reading_goals/reading_goal_progress, aligning the template path with the proper directory structure.

  • Updated template path reference in ReadingGoalProgress.generate() method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mekarpeles mekarpeles merged commit 267b401 into internetarchive:master Nov 6, 2025
10 checks passed
@mekarpeles mekarpeles self-assigned this Nov 6, 2025
@jimchamp jimchamp deleted the 10974/regression/progress-partial branch November 6, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants