refactor: Utilize semantic line-height LESS vars #11669
refactor: Utilize semantic line-height LESS vars #11669mekarpeles merged 3 commits intointernetarchive:masterfrom
Conversation
| &, | ||
| .sri__main { | ||
| display: flex; | ||
| align-items: center; |
There was a problem hiding this comment.
Is this change intentional?
There was a problem hiding this comment.
This change shouldn't be in this PR, I'll remove.
I do think the vertical centering of the cover image is odd, as it makes sense to me aligned to the top alongside the title. But this proposed design change should be separated out from this PR.
After
| @line-height-meta: @line-height-snug; // bylines, counts, timestamps, secondary text (search cards) | ||
|
|
||
| @line-height-list: @line-height-relaxed; // multi-line lists of links/subjects (subject pages) | ||
| @line-height-list: @line-height-snug; // multi-line lists of links/subjects (subject pages) |
There was a problem hiding this comment.
This is a fairly big change from 1.3 to 1.65. Is it intentional?
There was a problem hiding this comment.
The change goes the other way, from 1.65 to 1.3, making it tighter. It's something we can continue to tweak, but the reason to make it more snug was to to make the space between list items that are wrapping tighter so they don't appear like multiple distinct list items.
At-a-glance this appears to have 7 distinct list items
4 participants
Issue # #11555
This PR is a follow-up to:
refactor: Define Line Height LESS vars #11619
Technical
Utilizes new semantic line-height variables across various sections. It is not exhaustive but sets the precedent for how to set line-height moving forward.
Testing
Impact of this refactor is minimal with only a few line-height values changing, and those changes being small (0.2em or less difference in value).
Screenshot
Stakeholders
@cdrini @mekarpeles @jimchamp