Make all async functions for solr class#11772
Merged
Conversation
RayBB
force-pushed
the
refactor/solr-async
branch
from
8f842ac to
964c259
Compare
cdrini
reviewed
Feb 6, 2026
openlibrary/utils/solr.py
Outdated
|
|
||
| def get_many( | ||
| @functools.wraps(get_async) | ||
| def get(self, *args, **kwargs): |
Collaborator
There was a problem hiding this comment.
Tested switching these to use async_bridge.wrap and they appear to be working!
Auto-complete docs now also include the fn description. And type parameters are persisted as I think they were before.
Also confirmed the publishers page, which uses .select, populated correctly locally.
Collaborator
Author
There was a problem hiding this comment.
@cdrini that's an awesome improvement! Great find!
cdrini
approved these changes
Feb 6, 2026
Collaborator
cdrini
left a comment
cdrini
left a comment
There was a problem hiding this comment.
Lgtm! Tested on testing, publishers pages (which call select) work: https://testing.openlibrary.org/publishers/Standard_Ebooks
As does the my books page, which calls IIRC get_many: https://testing.openlibrary.org/people/ScarTissue/books/already-read?q=ebook_access%3Apublic
bhardwajparth51
added a commit
to bhardwajparth51/openlibrary
that referenced
this pull request
Feb 17, 2026
* make all async functions for solr class * remove useless docstrings * Switch to using async_bridge.wrap instead of functools.wraps * Remove sync Solr.session ; no longer used! --------- Co-authored-by: Drini Cami <cdrini@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make all async functions for solr class
This is a preparatory step so we can use these very soon.
Technical
Testing
Screenshot
Stakeholders