Fix reading stats double-counted if appearing 2+ times on same work#11802
Merged
Fix reading stats double-counted if appearing 2+ times on same work#11802
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes inflated counts on the “My Stats” page when the same work contributes multiple identical keys (e.g., the same author or category appearing more than once on a single work), which previously caused double-counting in the aggregations.
Changes:
- Deduplicates per-work keys used for grouping/aggregation in
createWorkChartby wrapping the filtered key list withuniq(...)so each work contributes at most once per key. - Keeps the existing exclusion logic intact while ensuring only unique, valid keys are used when populating the grouped stats data.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Auto-merging ; small one liner fix. Verified working on testing. |
bhardwajparth51
added a commit
to bhardwajparth51/openlibrary
that referenced
this pull request
Feb 17, 2026
…ix/duplicate-reading-stats Fix reading stats double-counted if appearing 2+ times on same work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11769
Technical
Testing
Screenshot
Before:
After:
Stakeholders