Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where an extra cls parameter was incorrectly passed to a classmethod call. When calling a classmethod on a class, Python automatically passes the class as the first argument, so explicitly passing cls as the first parameter results in the wrong arguments being passed to the method.
Changes:
- Fixed incorrect classmethod invocation in
submit_delete_requestby removing the redundantclsparameter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
The entire method should be deleted:
|
Member
|
Agreed, whole method can be deleted @RayBB |
Collaborator
Author
|
@mekarpeles the method is now deleted |
Collaborator
Author
|
Given the broad agreement, this is now merged. |
bhardwajparth51
added a commit
to bhardwajparth51/openlibrary
that referenced
this pull request
Feb 17, 2026
…atch-4 remove extra cls variable being passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just noticed this and it seems like it's wrong...
Why would we pass cls when it should be passed automatically.
Technical
Testing
Screenshot
Stakeholders