Skip to content

remove extra cls variable being passed#11808

Merged
RayBB merged 2 commits intomasterfrom
RayBB-patch-4
Feb 4, 2026
Merged

remove extra cls variable being passed#11808
RayBB merged 2 commits intomasterfrom
RayBB-patch-4

Conversation

@RayBB
Copy link
Collaborator

@RayBB RayBB commented Feb 3, 2026

I just noticed this and it seems like it's wrong...
Why would we pass cls when it should be passed automatically.

Technical

Testing

Screenshot

Stakeholders

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where an extra cls parameter was incorrectly passed to a classmethod call. When calling a classmethod on a class, Python automatically passes the class as the first argument, so explicitly passing cls as the first parameter results in the wrong arguments being passed to the method.

Changes:

  • Fixed incorrect classmethod invocation in submit_delete_request by removing the redundant cls parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jimchamp
Copy link
Collaborator

jimchamp commented Feb 3, 2026

The entire method should be deleted:

  • It is not referenced in the codebase
  • We have no notion of a "delete" type librarian request
  • This method does not set an mr_type, which is used to determine the typ of librarian request (work merge, author merge, etc.)

@mekarpeles
Copy link
Member

Agreed, whole method can be deleted @RayBB

@RayBB
Copy link
Collaborator Author

RayBB commented Feb 3, 2026

@mekarpeles the method is now deleted

@RayBB RayBB merged commit 21ad0ac into master Feb 4, 2026
8 checks passed
@RayBB RayBB deleted the RayBB-patch-4 branch February 4, 2026 00:36
@RayBB
Copy link
Collaborator Author

RayBB commented Feb 4, 2026

Given the broad agreement, this is now merged.

bhardwajparth51 added a commit to bhardwajparth51/openlibrary that referenced this pull request Feb 17, 2026
…atch-4

remove extra cls variable being passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants