Remove thingdb as source for patron preferences#11933
Merged
mekarpeles merged 1 commit intomasterfrom Feb 25, 2026
Merged
Conversation
jimchamp
changed the title
thingdb as source for patron preferences
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the User.preferences() accessor in openlibrary/core/models.py to stop reading patron preferences from the Infobase/ThingDB “thing” tables, and instead only read from the site.store tables (falling back to defaults if missing).
Changes:
- Removed the ThingDB fallback lookup for
/people/<user>/preferences. User.preferences()now returnssite.store.get(key)orget_default_preferences().
RayBB
pushed a commit
that referenced
this pull request
Feb 26, 2026
bhardwajparth51
pushed a commit
to bhardwajparth51/openlibrary
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advances #11009
Prevents patron preferences accessor from querying the
thingtables for preference objects.Untested.
Technical
Testing
Screenshot
Stakeholders