Merged
Conversation
RayBB
force-pushed
the
fastapi/server-static-assets
branch
from
f632366 to
289df48
Compare
Collaborator
Author
|
Works on testing. We aren't going to be using this until we start migrating html pages over but this along with #11966 brings us even closer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is preparation work for the FastAPI migration path. It aligns static asset serving between
web(web.py) andfast_web(FastAPI) so both stacks resolve/static/build/*consistently.What Changed
fast_webin compose.override.yaml:ol-build:/openlibrary/static/buildWhy
As we move toward serving HTML via FastAPI, we need static asset behavior to match the legacy stack. This prevents chunk/file mismatches between ports
8080and18080and gives us a stable base for upcoming HTML route migration.Verification
fast_webwith updated compose config./static/build/js/8839.b619318e1c5edfe88649.jsonweb/static/build/js/8839.b619318e1c5edfe88649.jsonfast_webWorks on testing:
https://testing.openlibrary.org/_fast/static/build/js/8839.d97e9cf55cfab38947b5.js
Screenshot
Stakeholders