Migrate /cdn/archive.org JS proxy endpoint to FastAPI#11969
Merged
RayBB merged 6 commits intointernetarchive:masterfrom Mar 1, 2026
Merged
Migrate /cdn/archive.org JS proxy endpoint to FastAPI#11969RayBB merged 6 commits intointernetarchive:masterfrom
RayBB merged 6 commits intointernetarchive:masterfrom
Conversation
for more information, see https://pre-commit.ci
RayBB
requested changes
Mar 1, 2026
Collaborator
RayBB
left a comment
There was a problem hiding this comment.
Looks good just a few docs updates
RayBB
reviewed
Mar 1, 2026
RayBB
approved these changes
Mar 1, 2026
Collaborator
RayBB
left a comment
There was a problem hiding this comment.
Everything looks prefect!
One small notes for my future self. Maybe we want to caching so we don't hit archive.org so often. But I'll have to ask for the logs to see if it matters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11966
Technical
Adds
openlibrary/fastapi/cdn.py— a new FastAPI router that mirrors the legacyia_js_cdnhandler inopenlibrary/plugins/openlibrary/code.py:donate.jsandathena.jsare accepted; all other filenames return 404https://archive.org/includes/{filename}with a 10s timeoutContent-Type: text/javascriptandCache-Control: max-age=86400, matching legacy headers exactlyopenlibrary/asgi_app.py; existing templates and service worker references (footer.html,donation_banner.html,service-worker-matchers.js) are unaffectedChanges
openlibrary/fastapi/cdn.pyopenlibrary/asgi_app.pycdn_routeropenlibrary/tests/fastapi/test_cdn.pyRequirements Checklist
donate.js|athena.js)Content-Type,Cache-Control)asgi_app.pyTesting
docker compose exec web pytest openlibrary/tests/fastapi/test_cdn.py -vStakeholders
@RayBB