Skip to content

use get_current_user when adding a book#12059

Merged
cdrini merged 2 commits intomasterfrom
fix/12043-threaded-dict-site
Mar 11, 2026
Merged

use get_current_user when adding a book#12059
cdrini merged 2 commits intomasterfrom
fix/12043-threaded-dict-site

Conversation

@RayBB
Copy link
Copy Markdown
Collaborator

@RayBB RayBB commented Mar 9, 2026

Closes #12043

Since I cannot reproduce the issue locally or on testing, I'm not totally sure if this will work.

Looking at the code path and where we are accessing a threaded dict, it seems like changing it to use the context variable is a very likely fix.

@cdrini what do you think?

Technical

Testing

Screenshot

Stakeholders

Copy link
Copy Markdown
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, we patch deployed this out and it fixed the issue! The recaptcha changes seem like a no-op, but it makes the code more logical. Note we were never able to repro this on testing or locally, and are unclear why.

@cdrini cdrini merged commit 2f5ac06 into master Mar 11, 2026
8 checks passed
@RayBB RayBB deleted the fix/12043-threaded-dict-site branch March 11, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'ThreadedDict' object has no attribute 'site' when adding a new book

2 participants