google signup screen issue fix with use of ResizeObserver#12128
google signup screen issue fix with use of ResizeObserver#12128numericals-org wants to merge 8 commits intointernetarchive:masterfrom
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
RayBB
left a comment
There was a problem hiding this comment.
There are still some white space changes. Could you please try to remove them and remove the changes to Semicolons too.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
RayBB
left a comment
There was a problem hiding this comment.
Please remove all the changes that aren't absolutely needed for the PR.
Additionally @lokesh do you think there's a different way we should do this? It seems a little brittle with all the hard coded IDs but I'm not sure what the alternative is when dealing with iframes.
|
Some feedback from AI review: ProblemResizeObserver won't work on a cross-origin iframe SolutionIA already sends postMessage events to OL, and OL already listens for them:
So the flow is: Google auth completes → IA sends s3-keys → OL submits the login form → page The fix is simple — hide the form and separator when a resize message makes the iframe taller. The function: if (e.data.type === 'resize') { } I would love to for us to be able to ditch iframe for a classic OAuth link flow, but that would require coordination w/IA. |
Closes #12063
Technical
Testing
Screenshot
Blocker
Stakeholders
@mekarpeles @cdrini