ol-chip: use close icon, add border-radius-chip token#12145
Merged
cdrini merged 1 commit intointernetarchive:masterfrom Mar 27, 2026
Merged
ol-chip: use close icon, add border-radius-chip token#12145cdrini merged 1 commit intointernetarchive:masterfrom
cdrini merged 1 commit intointernetarchive:masterfrom
Conversation
- Replace checkmark with close (X) icon on selected chips - Remove icon carousel hover animation on selected state - Add --border-radius-chip semantic token for chips - Refactor all semantic border-radius tokens to reference primitives Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lokesh
commented
Mar 20, 2026
| --border-radius-badge: 2px; /* badges, tags */ | ||
| --border-radius-notification: 8px; /* notifications, alerts */ | ||
| --border-radius-avatar: 50%; /* avatars, profile pictures */ | ||
| --border-radius-button: var(--border-radius-md); /* buttons, tabs */ |
Collaborator
Author
There was a problem hiding this comment.
I had overlooked this in a previous PR and used hardcoded values for these semantic tokens instead of the the primitives that are defined further up in this same file. Fixed here. No visual impact.
cdrini
approved these changes
Mar 27, 2026
Collaborator
cdrini
left a comment
cdrini
left a comment
There was a problem hiding this comment.
Lgtm! Looks great on testing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--border-radius-chipsemantic token so multi-line chips don't get an exaggerated pill shapeTest plan
Screenshots
'X' icon on left
border radius for multi-line chips renders with same value as single line
Stakeholders
@cdrini cc: @mekarpeles