Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a convenience make frontend target to build all frontend asset bundles (CSS, JS, Vue components, and Lit components) without running the full all pipeline.
Changes:
- Introduces a new
frontendMakefile target that depends oncss,js,components, andlit-components.
Agent-Logs-Url: https://github.com/internetarchive/openlibrary/sessions/8047d125-2f3a-48f5-b6b4-3cd8b4d0be95 Co-authored-by: jimchamp <28732543+jimchamp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the addition of Lit, it has become cumbersome to build all of our frontend files. With these changes in place, one need only call
make frontendto build our CSS, JS, Vue components, and Lit components.Technical
The
frontendtarget depends oncss,js,components, andlit-components. It is also declared in.PHONYto ensure the target always runs even if a file or directory namedfrontendexists.Testing
Screenshot
Stakeholders
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.